The official website for
the world of Catan

Question about General Questions Placed cards - When does the removal of certain buildings affect the receipt of resources and victory points?

Answer

In most cases, immediately. Exceptions are explicitly stated on the cards or in the game rules.